test(anvil): fix remaining TODOs/ignores, remove compiler dependency #7877
Conversation
| // Sending the transaction is successful but reverts on chain. | ||
| let tx = provider.send_transaction(tx).await.unwrap(); | ||
| let receipt = tx.get_receipt().await.unwrap(); | ||
| assert!(!receipt.inner.inner.status()); |
There was a problem hiding this comment.
send / send_transaction fail with gas estimation layer because the node returns an RPC error if the call/estimation fails, whereas without the layer the transaction will be sent directly to the node, returning a receipt with "status": false.
This test illustrates the difference in where the error happens.
| .await | ||
| .unwrap() | ||
| .into_stream() | ||
| .take(2) | ||
| .take(num_txs) | ||
| .fuse(); |
There was a problem hiding this comment.
*full boolean params is not implemented in anvil
| @@ -121,6 +121,9 @@ impl ProviderBuilder { | |||
| }) | |||
| .wrap_err_with(|| format!("invalid provider URL: {url_str:?}")); | |||
|
|
|||
| // Use the final URL string to guess if it's a local URL. | |||
| let is_local = url.as_ref().map_or(false, |url| guess_local_url(url.as_str())); | |||
There was a problem hiding this comment.
required to reduce polling interval for watch tests
| to: Default::default(), | ||
| value: U256::from(0) | ||
| } | ||
| to: Address::ZERO, |
There was a problem hiding this comment.
This was already zero but I'm not sure if this is correct, as selfdestruct technically has a to address. cc @sealer3
There was a problem hiding this comment.
You're right - for selfdestruct operations, type, from, to, and value should all be given in the ots_getInternalOperations response, using the smart contract being self-destructed as the from address and the target of the selfdestruct as the to address.
| @@ -153,6 +153,12 @@ pub fn transaction_request_to_typed( | |||
| } | |||
| } | |||
|
|
|||
| fn has_optimism_fields(other: &OtherFields) -> bool { | |||
There was a problem hiding this comment.
Fixes the optimism test, since it doesn't set the tx type explicitly
No description provided.