Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Priority fee suggestion #7984

Merged
merged 6 commits into from
Jun 1, 2024
Merged

feat: Priority fee suggestion #7984

merged 6 commits into from
Jun 1, 2024

Conversation

dorlneylon
Copy link
Contributor

Motivation

Removing the constant and instead calculating the capacity in eth api.

Solution

I'm not yet sure of the realisation, so needs review. For now I'm just getting the lowest value from the cache history, since in itself it should already be filtered by percentiles.

@dorlneylon dorlneylon changed the title Priority fee suggestion feat: Priority fee suggestion May 24, 2024
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better than using a constant,
supportive

some suggestions

crates/anvil/src/eth/api.rs Outdated Show resolved Hide resolved
crates/anvil/src/eth/api.rs Outdated Show resolved Hide resolved
crates/anvil/src/eth/api.rs Outdated Show resolved Hide resolved
@mattsse mattsse marked this pull request as ready for review May 24, 2024 10:43
@dorlneylon dorlneylon requested a review from mattsse May 24, 2024 12:00
@dorlneylon dorlneylon requested a review from DaniPopes May 26, 2024 09:34
@dorlneylon dorlneylon requested a review from DaniPopes May 27, 2024 07:08
@dorlneylon
Copy link
Contributor Author

@mattsse can I have your review, please?

@dorlneylon
Copy link
Contributor Author

@mattsse

@mattsse mattsse merged commit 2b95250 into foundry-rs:master Jun 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants