perf: exclude source maps from ContractData

[klkvr]

Motivation

ref #8014

Since #7937 ContractData stored entire CompactBytecode instead of just bytecode bytes. CompactBytecode includes source maps and thus results in increased memory usage to store those in known_contracts when running tests.

Solution

Introduce separate BytecodeData struct which does not keep source maps as we don't need them for bytecode identification.

cc @grandizzy

[mattsse]

lgtm

[DaniPopes]

How does this help? Are we cloning this structure?

[klkvr]

How does this help? Are we cloning this structure?

Yes, we build and keep separate ContractsByArtifact for each test suite since #7685

[grandizzy]

confirming memory does not exceed 4.5G with this PR (prev was 13G) 🎉

[DaniPopes]

Sure but it's Arc'd, if I remove derive(Clone) from ContractData or ContractsByArtifact only forge script related code is affected

[klkvr]

Sure but it's Arc'd, if I remove derive(Clone) from ContractData or ContractsByArtifact only forge script related code is affected

yeah we don't clone it in tests, the memory usage is coming from us building it for each test contract here and then not dropping till the end of test run

[DaniPopes]

Ah it's kept in suite result

[klkvr]

yep, we can optimize this by not linking test contracts separately and ensuring deterministic library addresses instead, will look into this

[DaniPopes]

Clearing it in tests should be fine, it's skipped in serde and not used after f8145ed