New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Result
from vm_memory.rs
methods instead of using expect
#65
Comments
Is it still relevant? |
Not sure, someone could take this issue and verify it it makes sense still. |
@cptartur Please include specific code locations when creating such issues, otherwise it is just: Check the whole codebase and see if we can do something better which is not very productive :p |
I think this task was created when the runner was still changing very rapidly, so it made sense back then ;P |
I've verified and it seems only methods that still have Updating the issue description |
Result
from vm_memory.rs
methods instead of using expect
software-mansion/protostar#2006
There are methods in
vm_memory.rs
usingexpect
. These should be changed to return anyhow result with relevant message. It should panic at thecheatcodes_hint_processor
level, or this method should be moved there.The text was updated successfully, but these errors were encountered: