Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account create does not return a valid json when --json flag is passed #678

Closed
1 task done
Tracked by #113
DelevoXDG opened this issue Sep 15, 2023 · 0 comments · Fixed by #1004
Closed
1 task done
Tracked by #113

account create does not return a valid json when --json flag is passed #678

DelevoXDG opened this issue Sep 15, 2023 · 0 comments · Fixed by #1004
Assignees
Labels
bug Something isn't working Team: sncast

Comments

@DelevoXDG
Copy link
Contributor

Which component is your bug related to?

Cast

Foundry Version

0.6.0

What operating system are you using?

MacOS

What system architecture are you using?

arm

What happened

sncast --json account create --name some_name --salt 20 --class-hash 0x4d07e40e93398ed3c76981e72dd1fd22557a78ce36c0515f679e27f0bb5bc5f

outputsj invalid json:

Account successfully created. Prefund generated address with at least 489600000000000 tokens. It is good to send more in the case of higher demand, max_fee * 2 = 979200000000000
{
  "add_profile": "--add-profile flag was not set. No profile added to Scarb.toml",
  "address": "0x1572310a068842fab0bc2a6b6f5e395a10c49e3a04cf242f0d2beb7a9b0cbdc",
  "command": "account create",
  "max_fee": "0x1bd49e2150000"
}

The text Account successfully created. Prefund generated address... can be handled like "add_profile": or removed from json output altogether.

Trace

No response

Is there an existing issue for this?

  • I have searched the existing issues and verified no issue exits for this problem.
@DelevoXDG DelevoXDG added the bug Something isn't working label Sep 15, 2023
@github-actions github-actions bot added the new label Sep 15, 2023
DelevoXDG added a commit to software-mansion/starknet-jvm that referenced this issue Sep 21, 2023
@THenry14 THenry14 removed the new label Oct 3, 2023
@THenry14 THenry14 self-assigned this Oct 30, 2023
github-merge-queue bot pushed a commit that referenced this issue Oct 31, 2023
#1004)

<!-- Reference any GitHub issues resolved by this PR -->

Closes #678

## Introduced changes

<!-- A brief description of the changes -->

- remove println! in account subcommands that were making cast output
with --json flag invalid

## Checklist

<!-- Make sure all of these are complete -->

- [X] Linked relevant issue
- [X] Updated relevant documentation
- [X] Added relevant tests
- [X] Performed self-review of the code
- [X] Added changes to `CHANGELOG.md`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Team: sncast
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants