Add delete account feature to remove an account from the accounts file. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnet0x
requested review from
THenry14 and
drknzz
and removed request for
a team
THenry14
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Looking very good, thanks for an amazing contribution 💪 A few smaller things to change/add but apart from that good job!
One think I'd like you to also add is delete subcommand appendix in docs - with the description of its arguments etc. Something very similar to what's already done (you can find appendix pages for account command in docs/src/appendix/cast/account - you can add delete.md there :) )
Co-authored-by: Wojciech Szymczyk <wojciech.szymczyk@swmansion.com>
|
Hi @devnet0x , was this closed on purpose? |
|
Hi, no, i think it was my mistake |
…onfirmations, etc)
|
gm..al conversations solved, please recheck. Thanks. |
THenry14
requested changes
Oct 4, 2023
drknzz
reviewed
Oct 13, 2023
drknzz
reviewed
Oct 17, 2023
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
Co-authored-by: Kamil Jankowski <kamil.jankowski.x@gmail.com>
|
Thanks for your advice, conversations solved and changes commited. |
|
Done, please your review @drknzz |
THenry14
reviewed
Oct 23, 2023
Fix prompt with a more clear message. Co-authored-by: Wojciech Szymczyk <wojciech.szymczyk@swmansion.com>
THenry14
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #498
Introduced changes
Add account delete feature to remove an account from a network in the accounts file.
Breaking changes
N/A
Checklist
CHANGELOG.md