Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isPC has been deprecated, but some scripts appear to still use it #152

Closed
RollToSaveVsDragons opened this issue Nov 2, 2020 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@RollToSaveVsDragons
Copy link

foundry_community_macros/module-specific/resolve_surprise.js:135: .filter((pc) => pc.actor.isPC && pc.actor.data.type === "character")

foundry_community_macros/module-specific/resolve_surprise.js:144: .filter((pc) => pc.actor.isPC && pc.actor.data.type === "character")

foundry_community_macros/module-specific/resolve_surprise.js:151: .filter((ec) => ec.actor.isPC === false && ec.data.disposition === -1)

foundry_community_macros/module-specific/resolve_surprise.js:160: .filter((ec) => ec.actor.isPC === false && ec.data.disposition === -1)

foundry_community_macros/misc/award_party_xp.js:5: let actors = game.actors.entities.filter(e => e.data.type === 'character' && e.isPC);

@AnthonyVadala AnthonyVadala added bug Something isn't working help wanted Extra attention is needed labels Nov 4, 2020
@Stratlin
Copy link

I encountered this in the following macro:

let actors = game.actors.entities.filter(e => e.data.type === 'character' && e.isPC);

I was able to quick and dirty fix it in that case by changing .isPc to .hasPlayerOwner . I haven't had time to extensively test it and I don't know if the fix is that simple for all macros but it seems to be working in that use case.

@AnthonyVadala
Copy link
Member

module-specific/resolve_surprise.js (and several other macros) are being removed in the upcoming v9 version of this module due to the module it depends no longer being updated.

misc/award_party_xp.js has been updated to work in the v9 development branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
No open projects
Development

No branches or pull requests

3 participants