'1dc' roll terms erroneously mapped to '1d2' in item derivedDamage labels #2281
Labels
Milestone
Comments
Fyorl
added
bug
|
I can work on this one. |
Hoppyhob
added a commit
to Hoppyhob/dnd5e
that referenced
this issue
Oct 15, 2023
Closes foundryvtt#2281 There was an issue in _simplifyDiceTerms where a Coin was reduced to its operator and number of faces, then assumed to be a die when passed back out. This ended up turning a coin into a die 2 and combining it with any other die 2s in the Dice Terms. This was fixed by using a c for the faces value if the DiceTerm is Coin and returning a DiceTerm of Coin, instead of Die, if the face value is c . (any DiceTerm other than Coin should default to using the number of faces and return as a Die DiceTerm)
Hoppyhob
added a commit
to Hoppyhob/dnd5e
that referenced
this issue
Oct 15, 2023
Closes foundryvtt#2281 There was an issue in _simplifyDiceTerms where a Coin was reduced to its operator and number of faces, then assumed to be a die when passed back out. This ended up turning a coin into a die 2 and combining it with any other die 2s in the Dice Terms. This was fixed by using a c for the faces value if the DiceTerm is Coin and returning a DiceTerm of Coin, instead of Die, if the face value is c . (any DiceTerm other than Coin should default to using the number of faces and return as a Die DiceTerm)
Hoppyhob
added a commit
to Hoppyhob/dnd5e
that referenced
this issue
Oct 15, 2023
Closes foundryvtt#2281 There was an issue in _simplifyDiceTerms where a Coin was reduced to its operator and number of faces, then assumed to be a die when passed back out. This ended up turning a coin into a die 2 and combining it with any other die 2s in the Dice Terms. This was fixed by using a c for the faces value if the DiceTerm is Coin and returning a DiceTerm of Coin, instead of Die, if the face value is c. (Any DiceTerm other than Coin should default to using the number of faces and return as a Die DiceTerm)
Fyorl
pushed a commit
that referenced
this issue
Oct 19, 2023
Co-authored-by: Kim Mantas <kim.mantas@gmail.com> Closes #2281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is purely a cosmetic issue and doesn't affect rolling. If you add one or more '1dc' terms in the damage formula for an item, the 'derivedDamage' labels shown in the description tab of that item will instead contain '1d2' (or 'nd2' for n terms). This is incorrect as '1dc' is equivalent to '1d2 - 1' and not '1d2' despite having two faces.
Anyway, this happens with zero enabled modules, v. 2.1.5 of the dnd5e system, and v. 10.291 of Foundry.
The text was updated successfully, but these errors were encountered: