Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow module-provided actor subtypes to use core data preparation #2495

Closed
JPMeehan opened this issue Oct 17, 2023 · 0 comments · Fixed by #2506
Closed

Allow module-provided actor subtypes to use core data preparation #2495

JPMeehan opened this issue Oct 17, 2023 · 0 comments · Fixed by #2506
Assignees
@arbron
Labels
api
Milestone
D&D5E 2.4.0

Comments

@JPMeehan
Copy link

As a developer making a module that leverages actor subtypes, I would like to be able to use the system.prepareBaseData() and system.prepareDerivedData() methods that are naturally part of Foundry's data preparation cycle. Unfortunately, the Actor5e class fully suppresses those methods. I would like to be able to use natural foundry data preparation processes to support my module subtypes.

Related to #2094
This was referenced Oct 18, 2023
Closed
Closed
@Fyorl Fyorl added the api label Oct 19, 2023
@Fyorl Fyorl added this to the D&D5E 2.4.0 milestone Oct 19, 2023
@arbron arbron self-assigned this Oct 20, 2023
arbron added a commit to arbron/dnd5e that referenced this issue Oct 20, 2023
@arbron
[foundryvtt#2495] Allow prepareData methods to be called on module ac…
d9874b6 
…tors
arbron added a commit to arbron/dnd5e that referenced this issue Oct 20, 2023
@arbron
[foundryvtt#2495] Allow prepareData methods to be called on module ac…
c42e55d 
…tors
arbron added a commit to arbron/dnd5e that referenced this issue Oct 20, 2023
@arbron
[foundryvtt#2495] Allow prepareData methods to be called on module ac…
06e1ec1 
…tors
@arbron arbron linked a pull request Oct 20, 2023 that will close this issue
[#2495] Allow prepareData methods to be called on module actors #2506
Merged
@Fyorl Fyorl mentioned this issue Oct 25, 2023
Merged
arbron added a commit to arbron/dnd5e that referenced this issue Oct 25, 2023
@arbron
[foundryvtt#2495] Allow prepareData methods to be called on module ac…
08988ce 
…tors
arbron added a commit to arbron/dnd5e that referenced this issue Oct 25, 2023
@arbron
[foundryvtt#2495] Allow prepareData methods to be called on module ac…
58d565c 
…tors
arbron added a commit to arbron/dnd5e that referenced this issue Oct 25, 2023
@arbron
[foundryvtt#2495] Minor code style cleanup
6edbe8e
arbron added a commit that referenced this issue Oct 25, 2023
@arbron
Merge pull request #2506 from arbron/typedata
dc827e1 
[#2495] Allow prepareData methods to be called on module actors
@arbron arbron closed this as completed Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arbron arbron

Labels
api
Projects
None yet
Milestone
D&D5E 2.4.0
Development

Successfully merging a pull request may close this issue.

[#2495] Allow prepareData methods to be called on module actors arbron/dnd5e
3 participants
@Fyorl @JPMeehan @arbron