Don't display scrolling combat text if the token is secret #3728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev7355608
commented
Jun 11, 2024
| @@ -3341,7 +3341,7 @@ export default class Actor5e extends SystemDocumentMixin(Actor) { | |||
| const fill = CONFIG.DND5E.tokenHPColors[key]; | |||
|
|
|||
| for ( const token of tokens ) { | |||
| if ( !token.object?.visible || !token.object?.renderable ) continue; | |||
| if ( !token.object?.visible || token.isSecret ) continue; | |||
There was a problem hiding this comment.
TokenDocument#isSecret will be an addition with V12 Stable 4. Considering it is undefined in prior versions, we don't really need a version check here, I think.
dev7355608
commented
Jun 11, 2024
| @@ -3341,7 +3341,7 @@ export default class Actor5e extends SystemDocumentMixin(Actor) { | |||
| const fill = CONFIG.DND5E.tokenHPColors[key]; | |||
|
|
|||
| for ( const token of tokens ) { | |||
| if ( !token.object?.visible || !token.object?.renderable ) continue; | |||
There was a problem hiding this comment.
We removed renderable in core ActiveEffect#_displayScrollingStatus with V12 Stable 4. Removing renderable makes the combat scrolling text appear when the token config is open, which wasn't the case previously.
Fyorl
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related core changes: https://github.com/foundryvtt/foundry-vtt/pull/2478