Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProseMirror: The ProseMirrorKeyMaps plugin and internal implementation doesn't respect multiple open editors #10139

Open
5 of 6 tasks
typhonrt opened this issue Oct 27, 2023 · 1 comment
Labels
bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor

Comments

@typhonrt
Copy link

typhonrt commented Oct 27, 2023

What happened?

The internal handling of the ProseMirrorKeyMaps plugin is always active for the last editor to be opened even if it isn't the current actively selected editor. A quick way to see the symptoms is to open two editors and in the attached video item A is opened before item B. Go back to item A and hit Ctrl-S to save and Item B is saved. Hit Ctrl-S again and errors will be thrown as Item B is still the target of the internal PM implementation.

While this issue pertains to key mapping there may be other internal state aspects to prosemirror.js / PM implementation that doesn't play nice w/ multiple editors open.

foundry-pm-bug.mp4

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

Described above

  • open 1 or more editors
  • the last editor opened remains the target of keymap / key handling regardless of which editor currently is focused.

What core version are you reporting this for?

v11.313

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@typhonrt typhonrt added the bug Functionality which is not working as intended label Oct 27, 2023
@aaclayton aaclayton added the text-editor Issues related to the ProseMirror or legacy TinyMCE text editor label Oct 30, 2023
@aaclayton aaclayton added this to the V11 - Stable Maintenance 12 milestone Oct 30, 2023
@Fyorl Fyorl removed this from the V11 - Stable Maintenance 12 milestone Oct 31, 2023
@Fyorl
Copy link
Contributor

Fyorl commented Oct 31, 2023

Moving to ProseMirror epic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor
Projects
Status: No status
Development

No branches or pull requests

3 participants