Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Maintenance - Prose Mirror Editors #51

Open
kgar opened this issue Nov 18, 2023 · 1 comment
Open

Style Maintenance - Prose Mirror Editors #51

kgar opened this issue Nov 18, 2023 · 1 comment
Labels
style Style changes are needed

Comments

@kgar
Copy link
Owner

kgar commented Nov 18, 2023

Review the styles for prose mirror editors. Ideally, prose mirror editor styles should be consolidated into a single SCSS file that affects actors, items, and any other Tidy 5e content which leverages these editors. Any customizations atop that should either be located closer to where they are relevant or eliminated in favor of making the experience consistent wherever these editors may be found.

Some visual issues discovered:

image
image
image

When hovering, the font is visible:
image
When not hovering, it is basically white on white:
image

@kgar kgar added the style Style changes are needed label Nov 18, 2023
@kgar
Copy link
Owner Author

kgar commented Nov 18, 2023

https://discord.com/channels/732325252788387980/1116078321067892796/1175338919341072516

TyphonJS (Michael) [UTC-7]
TRL provides pre-made editor components for ProseMirror with CSS variables to control styles of the menu and more w/ connection to a document / update mechanism. A general note is that the core ProseMirror editor implementation is borked on v11 w/ multiple editors open at the same time. foundryvtt/foundryvtt#10139. With the next TRL release out shortly the PM editor component will close when another opens to at least not fall afoul of that core bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style Style changes are needed
Projects
None yet
Development

No branches or pull requests

1 participant