Bug in TextEditor#_onDragEntityLink

[aaclayton]

Originally in GitLab by @mbrunninger

In order to submit an effective bug report, please include the following information along with your issue description.

Environment Details

Please share the following basic details about your setup.

• Foundry VTT Version: (Example 0.8.9)
• Operating System: [Windows]
• How Are You Using Foundry: [Firefox]

Issue Description

The code shown below checks pack.index.length, which must be pack.index.size for a.dataset.lookup to work properly.

index is a Map, not an Array.

foundry.js:21670-21679 (TextEditor#_onDragEntityLink)

if ( a.dataset.pack ) {
  const pack = game.packs.get(a.dataset.pack);
    let id = a.dataset.id;
    if ( a.dataset.lookup && pack.index.length ) {
                                        ^^^^^^
      const entry = pack.index.find(i => (i._id === a.dataset.lookup) || (i.name === a.dataset.lookup));
      if ( entry ) id = entry._id;
    }
  if ( !id ) return false;
  dragData = { type: pack.entity, pack: pack.collection, id: id };
}

[aaclayton]

Originally in GitLab by @mbrunninger

mentioned in issue mbrunninger/fvtt-hexxen-1733-core#29