The CanvasVisionMask, WeatherEffects#weather, and CanvasBackgroundAlterationEffects#vision containers are missing filterArea

[dev7355608]

Environment Details

• Foundry VTT Version: 10.270

Issue Description

If the filterArea is not set, the bounds of the container are calculated every frame if a filter is applied, which can have a noticeable performance impact at least in the case of the weather container. It might even be a good idea to override bounds calculation for the reason that a filter might be attached to one of the parents of the weather container: this would cause bounds calculation of the weather container, if no filterArea is set on the parent.

class ParticleContainer extends PIXI.Container {
    filterArea = canvas.app.screen;
    accessibleChildren = false;
    interactiveChildren = false;

    calculateBounds() {
        const bounds = this._bounds;
        const { x, y, width, height } = canvas.dimensions.rect;
        bounds.clear();
        bounds.addFrame(this.transform, x, y, x + width, y + height);
        bounds.updateID = this._boundsID;
    }
}

The InterfaceCanvasGroup also doesn't have filterArea set.

[Feu-Secret]

Good suggestion!

[Feu-Secret]

Overview of the changes:

• Added the filterArea = canvas.app.renderer.screen in CanvasVisionMask, WeatherEffects#weather and CanvasBackgroundAlterationEffects#vision
• Added a new specialized container FullCanvasContainer, where bounds are not computed with children, but with canvas dimensions.
• WeatherEffects#weather is now a FullCanvasContainer