Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision Limitation Threshold is broken #7467

Closed
dev7355608 opened this issue Jul 10, 2022 · 1 comment
Closed

Vision Limitation Threshold is broken #7467

dev7355608 opened this issue Jul 10, 2022 · 1 comment
Assignees
Labels
bug Functionality which is not working as intended vision Issues related to Token vision and vision modes

Comments

@dev7355608
Copy link

Environment Details

  • Foundry VTT Version: 10.272

Issue Description

VisionSource#initialize:

    // Compute the constrained vision polygon
-   if ( canvas.scene.globalLight ) {
+   if ( canvas.effects.illumination.globalLight ) {
      this.radius = canvas.dimensions.maxR;
      this.fov = this.los;
    }
    else {

CanvasVisibility#testVisibility:

    const tests = offsets.map(o => ({
      point: new PIXI.Point(point.x + o[0], point.y + o[1]),
      hasLOS: false,
-     hasFOV: canvas.scene.globalLight
+     hasFOV: canvas.effects.illumination.globalLight
    }));
@dev7355608 dev7355608 added the bug Functionality which is not working as intended label Jul 10, 2022
@aaclayton aaclayton added the vision Issues related to Token vision and vision modes label Jul 11, 2022
@aaclayton aaclayton added this to the Version 10 - Development 3 milestone Jul 11, 2022
@aaclayton aaclayton self-assigned this Jul 13, 2022
@aaclayton
Copy link
Contributor

Thanks for the report and fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended vision Issues related to Token vision and vision modes
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants