Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaptiveColorationShader.defaultUniforms.colorationAlpha should be 1 #7693

Closed
2 of 6 tasks
dev7355608 opened this issue Jul 29, 2022 · 1 comment
Closed
2 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended lighting/fog Issues related to dynamic lighting or fog of war

Comments

@dev7355608
Copy link

What happened?

        // Default 1 -> The remaining techniques use adaptive lighting,
        // which produces interesting results in the [0, 2] range.
        u.colorationAlpha = this.data.alpha * 2;

The default technique is 1, so the default value for the colorationAlpha uniform should be 1 (initial.alpha * 2).

This could theoretically matter for an isRequired implementation of a custom coloration shader. Probably very unlikely though.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

AdaptiveColorationShader.defaultUniforms.colorationAlpha

What core version are you reporting this for?

Version 10 Testing 2 (build 276)

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@dev7355608 dev7355608 added the bug Functionality which is not working as intended label Jul 29, 2022
@aaclayton aaclayton added this to the Version 10 - Testing 3 milestone Jul 30, 2022
@aaclayton aaclayton added the lighting/fog Issues related to dynamic lighting or fog of war label Jul 30, 2022
@Feu-Secret Feu-Secret self-assigned this Jul 30, 2022
@Feu-Secret
Copy link

Feu-Secret commented Aug 1, 2022

AdaptiveColorationShader.defaultUniforms.colorationAlpha default is now at the right value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended lighting/fog Issues related to dynamic lighting or fog of war
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants