Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The deletionKeys parameter of diffObject does not correctly ignore deletion keys in inner objects where the key targeted for deletion would be removed or does not exist #7716

Closed
aaclayton opened this issue Aug 1, 2022 · 0 comments
Assignees
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended

Comments

@aaclayton
Copy link
Contributor

Comment from @dev7355608

This hasn't been fixed entirely. Nonnested delete keys don't trigger an update event anymore if the key doesn't exist:

await canvas.scene.update({ "-=akeythatdoesnotexist": null });

But nested delete keys still trigger an update. Here the second update triggers updateScene even though nothing changed.

await canvas.scene.update({ flags: { core: { test: 1 } } });
Hooks.on("updateScene", (...args) => console.log("updateScene", args[1]));
await canvas.scene.update({ flags: { core: { "-=akeythatdoesnotexist": null } } });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issues related to the API used by Mod Devs bug Functionality which is not working as intended
Projects
No open projects
Development

No branches or pull requests

3 participants