Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply a minor styling change to improve the margin and padding applied to journal entry content and page edit views. #7792

Closed
arcanistzed opened this issue Aug 9, 2022 · 1 comment
Closed

Apply a minor styling change to improve the margin and padding applied to journal entry content and page edit views. #7792

arcanistzed opened this issue Aug 9, 2022 · 1 comment
Assignees
@aaclayton
Labels
journal Issues related to the Journal and Pages systems ui Issues focused on user interface improvements
Milestone
Version 10 - Stable

Comments

@arcanistzed
Copy link

User Experience

The viewing sheet has a padding at the bottom which looks great:
image
The editing sheet has padding on all sides, but not the bottom, which looks a lot more crowded since the text mixes in with the background:
image
@arcanistzed arcanistzed changed the title Minor style change: add padding to bottom of JournalTextPageSheet Minor style change: add padding to bottom of the journal page sheets Aug 9, 2022
@aaclayton aaclayton added ui Issues focused on user interface improvements journal Issues related to the Journal and Pages systems labels Aug 9, 2022
@aaclayton aaclayton added this to the Version 10 - Testing 4 milestone Aug 9, 2022
@Fyorl
Copy link
Contributor

Fyorl commented Aug 11, 2022

I think this is TinyMCE only. The ProseMirror editor has padding at the bottom.

@aaclayton aaclayton self-assigned this Aug 30, 2022
@aaclayton aaclayton changed the title Minor style change: add padding to bottom of the journal page sheets Apply a minor styling change to improve the margin and padding applied to journal entry content and page edit views. Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaclayton aaclayton

Labels
journal Issues related to the Journal and Pages systems ui Issues focused on user interface improvements
Projects
No open projects
Foundry VTT - Version 10
Status: Done
Milestone
Version 10 - Stable
Development

No branches or pull requests
3 participants
@Fyorl @aaclayton @arcanistzed