Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkvision rendering doesn't work properly when multiple tokens are selected #8507

Closed
2 of 6 tasks
Zamrod opened this issue Nov 11, 2022 · 2 comments
Closed
2 of 6 tasks
Assignees
Labels
bug Functionality which is not working as intended lighting/fog Issues related to dynamic lighting or fog of war vision Issues related to Token vision and vision modes

Comments

@Zamrod
Copy link

Zamrod commented Nov 11, 2022

What happened?

Darkvision rendering doesn't work properly when multiple tokens are selected.
The turning of dim light into bright light does not function and if one token cannot see an area it is always rendered in greyscale even if in light.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

Use this scene and select multiple tokens.
fvtt-Scene-greyscale-test2.txt

What core version are you reporting this for?

Version 10.290

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@Zamrod Zamrod added the bug Functionality which is not working as intended label Nov 11, 2022
@Feu-Secret Feu-Secret added lighting/fog Issues related to dynamic lighting or fog of war vision Issues related to Token vision and vision modes labels Nov 14, 2022
@Feu-Secret Feu-Secret self-assigned this Nov 14, 2022
@aaclayton
Copy link
Contributor

@TheElderMindseeker commented:

What happened?

When several player tokens share vision and at least one of them has darkvision, the shared vision in light becomes greyscale (as if in dark) even though it should be in color (as if in normal vision).

Although I like how certain characters with dark vision make everything go noir, I suppose it's a bug from technical point of view.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

Create a world with Pathfinder 2e or DnD 5e system (probably would work with any system) without any add-on modules. Create a player (or a trusted player) in the User Management. Create two player-owned sheets (Player Character) and assign ownership to the created player. Assign Darkvision of at least 120 ft to one of the tokens but leave only Basic Vision to the other (either through Rules-Based Vision or manually in Token Settings/Vision).

Create an empty scene with non-grey color such as (HEX 7382f2) big enough to place 60 ft light (2000 px by 2000 px is good). Enable Token Vision and, optionally, Fog Exploration on this scene. Activate the scene. Place a light with 60 ft dim light and 30 ft bright light somewhere in the corner. Transition the scene to darkness using Light Controls.

Place both actor tokens in the dim light area (or just somewhere on the map). Log in as a player. The scene should look okay with colorized lit area and greyscale out-of-light area. Select and then de-select token with Basic Vision. All should remain okay. Select and de-select token with Darkvision. Now the lit area is greyscale though it should be colorized. Selecting Basic Vision token gets the vision right until de-selected. Note: in DnD 5e the scene colors are greyscale even without selecting/de-selecting tokens.

Here is how the light setup of the scene should look like:

Foundry Vision Bug

Here is the demonstration of the effect:

bug.mp4

Video captured on V10 build 290 with Pathfinder 2e 4.4.0 on Linux machine;
Bug reproduced in Chrome, Firefox and Native App (Electron);
Bug reproduced using Pathfinder 2e 4.4.0 and DnD 5e 2.0.3;
Bug reproduced both on Linux and Windows. Mac unavailable.

What core version are you reporting this for?

Version 10 build 290

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled

@aaclayton
Copy link
Contributor

@Yesat commented:

It was reported with #8061 and then closed.
I have setup a quick scene with an "observer" player who doesn't control any token but can see everything the other token see.
The map:
image
The token without darkvision:
image
The tokens with darkvision:
image
image
The observer POV, with everything in grey scale and no module loaded.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended lighting/fog Issues related to dynamic lighting or fog of war vision Issues related to Token vision and vision modes
Projects
No open projects
Development

No branches or pull requests

3 participants