Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor without button ignores editable flag #8534

Closed
3 of 6 tasks
DJ4ddi opened this issue Nov 17, 2022 · 1 comment
Closed
3 of 6 tasks

Editor without button ignores editable flag #8534

DJ4ddi opened this issue Nov 17, 2022 · 1 comment
Assignees
Labels
bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor

Comments

@DJ4ddi
Copy link

DJ4ddi commented Nov 17, 2022

What happened?

When creating an editor without a button, e.g. by using the Handlebars helper, the editor is always editable - regardless of what was passed in for the editable option.

My goal is to create an editor that is read-only by default and activate it using my own logic.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

  1. Create or edit a Handlebars sheet for any entity.
  2. Add an editor with button=false and editable=false, e.g. with {{editor data.system.description target="system.description" editable=false engine="prosemirror"}}.
  3. Render the sheet. Observe how the editor is always editable.

What core version are you reporting this for?

10.290

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled
@DJ4ddi DJ4ddi added the bug Functionality which is not working as intended label Nov 17, 2022
@DJ4ddi
Copy link
Author

DJ4ddi commented Nov 17, 2022

It should be noted that both values (button and editable) default to false. Assuming that the described behavior is changed, it might make more sense to default editable to true (which currently doesn't matter).

@Fyorl Fyorl added the text-editor Issues related to the ProseMirror or legacy TinyMCE text editor label Nov 17, 2022
@Fyorl Fyorl added this to the Version 10 - Stable Patch 6 milestone Nov 17, 2022
@Fyorl Fyorl self-assigned this Nov 17, 2022
@Fyorl Fyorl closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended text-editor Issues related to the ProseMirror or legacy TinyMCE text editor
Projects
No open projects
Development

No branches or pull requests

2 participants