Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the computation of polygons which include threshold wall attenuation regions. #9531

Open
dev7355608 opened this issue May 30, 2023 · 3 comments
Labels
bug Functionality which is not working as intended tech-debt Issues focused on the reduction of technical debt vision Issues related to Token vision and vision modes walls Issues related to Walls and their configuration

Comments

@dev7355608
Copy link

dev7355608 commented May 30, 2023

Related Issues

Being in proximity of two walls with threshold attenuation at the same time can lead to unexpected results.

wall-threshold-attenuation-bug-1

wall-threshold-attenuation-bug-2

attenuationbug2

@dev7355608 dev7355608 added bug Functionality which is not working as intended vision Issues related to Token vision and vision modes labels May 30, 2023
@dev7355608 dev7355608 added this to the V11 - Stable Maintenance milestone May 30, 2023
@dev7355608 dev7355608 self-assigned this May 30, 2023
@dev7355608 dev7355608 added the walls Issues related to Walls and their configuration label Jun 3, 2023
@aaclayton
Copy link
Contributor

Comment from @Drental

What happened?

the view through the south window gets larger when my character approaches the left window, and then the south wall becomes fully opaque when stepping away from the attenuation distance.

What ways of accessing Foundry can you encounter this issue in?

  • Native App (Electron)
  • Chrome
  • Firefox
  • Safari
  • Other

Reproduction Steps

image
image
image

What core version are you reporting this for?

11.300

Relevant log output

No response

Bug Checklist

  • The issue occurs while all Modules are disabled

@dev7355608 dev7355608 removed this from the V11 - Stable Maintenance 5 milestone Jul 4, 2023
@aaclayton aaclayton added this to the V12 - Prototype 1 milestone Jul 17, 2023
@aaclayton aaclayton changed the title Wall threshold attenuation computation is flawed Improve the computation of polygons which include threshold wall attenuation regions. Jul 17, 2023
@Fyorl
Copy link
Contributor

Fyorl commented Oct 2, 2023

From #10038:

Originally reported by gambettv https://discord.com/channels/170995199584108546/1065764070680186930/1145761218854912020

ALL MODULES DISABLED? true
OS, Hosting, Browser (if applicable): Windows 10, Foundry 11 App
Short Description of bug: Wall Proximity Threshold Attenuation does not always behave as intended. Sometimes I can see further away through a window when I'm further away from it than when I'm closer to it, and normal Proximity is selected.
Screenshots do show some modules activated but it works the same even with everything disabled.

image

image

Adding on to the above: This is with all 4 windows set to 20 foot proximity, and if you measure per pixel from the center of the token, the distance I've revealed out all four windows is an equal distance from my token. This might be an error, I'm not sure. But it seems like it's related, in that once I get close enough to one of the windows to fully see out of it, you'll notice in screenshot 2 I can now see fully out all 3 windows. The 4th window I cannot see out at all. It seems like if you're close enough to one window, you can see out all windows you have any proximity threshold to whatsoever. There are windows all over this little block BTW, I'm just only able to see out a few of them depending on my proximity to them.

image

image

fvtt-Scene-test-Jf5CvZdN6top70Cy.zip

@aaclayton aaclayton removed their assignment Mar 18, 2024
@aaclayton aaclayton removed this from the V12 - API Development 2 milestone Mar 26, 2024
@dev7355608
Copy link
Author

Originally reported by maxobremer https://discord.com/channels/170995199584108546/1065764070680186930/1218942438333218876

ALL MODULES DISABLED? True
OS, Hosting, Browser (if applicable): WIN10, local
Short Description of bug:
When a token is close enough to a wall that is set up as a window (proximity with threshold attenuation) it can see through any window wall that it is in range of (range here being within the range where the proximity threshold attenution would be in effect)

in the first pic you can see what the token should see when its that far away from a window, but in pic 2 it can see way more through the window on the left, because its close to the window on the right

image
image

@aaclayton aaclayton added the tech-debt Issues focused on the reduction of technical debt label Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality which is not working as intended tech-debt Issues focused on the reduction of technical debt vision Issues related to Token vision and vision modes walls Issues related to Walls and their configuration
Projects
None yet
Development

No branches or pull requests

3 participants