Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Weakness Rule Elements proc for each damage type #16190

Open
JamzTheMan opened this issue Aug 22, 2024 · 1 comment
Open

Custom Weakness Rule Elements proc for each damage type #16190

JamzTheMan opened this issue Aug 22, 2024 · 1 comment
Labels
feature request iwr Issues and PRs related to immunities, weaknesses, and resistances

Comments

@JamzTheMan
Copy link
Contributor

JamzTheMan commented Aug 22, 2024

Given the below Custom Weakness RE, a Strike with property runes (say, cold, electricity, force) will add the Weakness 4 times.

{
  "definition": [
    "action:strike"
  ],
  "key": "Weakness",
  "label": "Blessed Counterstrike Weakness",
  "type": "custom",
  "value": "7"
}

Given that Weaknesses (shouldn't?) stack, these should be aggregated together and taken once. (granted there may be arguments for "instances of damage" so worse case an applyOnce or applyAll option could be added to let it be single or multi instance weakness?)

https://2e.aonprd.com/Rules.aspx?ID=2317
If more than one weakness would apply to the same instance of damage, use only the highest applicable weakness value. This usually only happens when a creature is weak to both a type of damage and a material or trait, such as a cold iron axe cutting a monster that has weakness to cold iron and slashing.

@stwlam
Copy link
Collaborator

stwlam commented Aug 23, 2024

An instance of damage is basically a damage type. I agree there's a need for "contact" custom weaknesses similar to how water and salt work, so we'll look into adding an option for a custom weakness to identify itself as such.

@simonward simonward added the iwr Issues and PRs related to immunities, weaknesses, and resistances label Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request iwr Issues and PRs related to immunities, weaknesses, and resistances
Projects
None yet
Development

No branches or pull requests

3 participants