Compatibility v10 #56

adrien-schiehle · 2022-08-13T18:49:19Z

The first three commits seems to come from somethink we already merged : Refresh button + category sort
I don't know why it is back in this PR :(

The rest is V10 compliance + entry pages for new Journal management

13-08-2022:
I recently added some additionnal changes du to another change in WA API.
And while doing it, I added a new buttion for shrinking categories in the journal.
(When you have a big WA world, it become difficult to navigate without it)

adrien-schiehle · 2022-08-13T18:53:43Z

Conflict seems to come from the fact I didn't retrieve all the changes that has been done during reviews.

I will try to see today how to do it with githubDesktop

Improve image identification and category sorting

# Conflicts: # module/framework.js # module/journal.js

adrien-schiehle · 2022-08-13T19:26:25Z

We may need to discuss what we want in term of pages for this v10

For now, I have :

One main page called Article / Character with the main WA Article content
Some additional pages named Portrait / Cover / Image. (It's what was previously in journal.img)
Two pages named Side content and Secrets for other sections. (Only section with id seeded is for now inside Secrets page)
One last one for Relations. (this one is not totally ok for now)

There will also be a question on which one should be displayed first : Article or Image

…s able to see a fine version of the image by itself

aaclayton

I like what you've done here to allocate the sections of the source WA article to different pages. I am not really sold on the idea of having a bunch of settings, do you think that users will really care to configure this? Could we simplify things and make this the default behavior?

module.json

aaclayton · 2022-08-17T14:13:55Z

module/config.js

@@ -106,5 +106,61 @@ export default class WorldAnvilConfig extends FormApplication {
      config: true
    });

+    // Add the customizable labels for each importable page
+    //-------------------
+    game.settings.register("world-anvil", "mainArticlePage", {


These settings feel like a level of customization that may not be necessary to me - I wonder if we could keep it simpler at first and see what feedback we get from users?

See comment bellow.

The parameters are far from being mandatory. An good alternative could be to create translation file for every language. Or ate the least put how to create on with the necessary data inside the Readme file.

module/journal.js

aaclayton · 2022-08-17T14:15:45Z

templates/journal.hbs

@@ -2,15 +2,19 @@
 {{#if this.hasContent}}
 <section class="category" data-category-id="{{ this.id }}" data-folder-id="{{ this.folder.id }}">
    <header class="category-header flexrow">
+        <i title="{{ localize 'WA.ButtonUnshrinkCategory' }}"


Places like this are a good opportunity to use the new tooltips API instead of a standard HTML title

Suggested change

<i title="{{ localize 'WA.ButtonUnshrinkCategory' }}"

<i data-tooltip="{{ localize 'WA.ButtonUnshrinkCategory' }}"

I've put data-tooltip= where we had title=. I gives a nice display.

I'm curious: Is there a way to alter those tooltip css ?
I will surely use it in my custom system. But all my custom made tooltips are written in black, with a cornsilk background

aaclayton · 2022-08-17T14:17:15Z

wa.css

+#world-anvil-browser .window-content {
+    max-height: 80vh;
+}


Is this necessary?

Without it, if you have a give world anvil world, it tends to take the whole screen.
I found it doesn't fit well, so added this.

What it does without this parameter :

aaclayton · 2022-08-17T14:25:30Z

wa.js

@@ -114,6 +114,9 @@ Hooks.on("renderJournalSheet", (app, html, data) => {
      }
    }
  }
+});
+
+Hooks.on("renderJournalPageSheet", (app, html, data) => {

  // Activate cross-link listeners
  html.find(".wa-link").click(event => {


It does not need to be part of this merge, but we have a new V10 feature for declaring custom text enrichments which can be used instead of this custom logic.

You can add a TextEditorEnricher to CONFIG.TextEditor.enrichers which provides a regex pattern and a replacer callback function.

Hoho,
Good to know. I will try to se how it works

adrien-schiehle · 2022-09-03T13:44:41Z

I like what you've done here to allocate the sections of the source WA article to different pages. I am not really sold on the idea of having a bunch of settings, do you think that users will really care to configure this? Could we simplify things and make this the default behavior?

I don't really remember why I choose to put them as parameters.

Perhaps, to allow people who only import characters to hand the page named Character instead of Article ?
Or Perhaps to allow peaple using another language to use the module "as it is" without having to get a whole module translation file. (The GM seeing english text inside WAJournalBrowser is ok. But players seeing text in english when opening a Journal can tend to be a little anticlimatic)

I'm french myself.
Until now, I didn't see the need to add a fr.json file to the project, since it was mainly for GM.
I'm lucky : Article, Portrait, and Secrets are spelled the same in french, so I won't have the need. But it will be different for german people

aaclayton · 2022-09-05T14:43:31Z

Thanks! I'll merge this in and cut a V10 compatible release :)

adrien-schiehle added 10 commits June 29, 2022 20:44

refresh + img fix + category sort

2c83af5

Reviews + hidding folderId

19971c2

Review

7e67771

V10 compliance

3ad98c1

Managing entry pages

43adee0

compatibility V10

9e7bca6

compatibility V10

5da8986

API Change in WA + Uncategoried fix + Shrinking categories + css

f241d34

Compatible core version : 10

58f99a4

New shrink button translation

1d217bb

adrien-schiehle added 2 commits August 13, 2022 20:55

Merge pull request #1 from foundryvtt/master

ce8dabf

Improve image identification and category sorting

Merge branch 'master' into compatibilityV10

76193b1

# Conflicts: # module/framework.js # module/journal.js

adrien-schiehle added 4 commits August 14, 2022 01:02

We remove <a .../> element surrounding the image, since now Foundry i…

d339715

…s able to see a fine version of the image by itself

Relationship management

57e80f0

Page names are customisable

59814cd

Shrink icon on left part. Better.

8a38e3e

aaclayton requested changes Aug 17, 2022

View reviewed changes

adrien-schiehle added 3 commits September 3, 2022 22:06

module.json v10 compliant

fbf74e3

shrink => collapsed

74690f8

Using data-tooltip

f7782fd

aaclayton merged commit ba09fec into foundryvtt:master Sep 5, 2022

adrien-schiehle deleted the compatibilityV10 branch September 10, 2023 21:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compatibility v10 #56

Compatibility v10 #56

adrien-schiehle commented Aug 13, 2022

adrien-schiehle commented Aug 13, 2022

adrien-schiehle commented Aug 13, 2022 •

edited

aaclayton left a comment

aaclayton Aug 17, 2022

adrien-schiehle Sep 3, 2022

aaclayton Aug 17, 2022

adrien-schiehle Sep 3, 2022

aaclayton Aug 17, 2022

adrien-schiehle Sep 3, 2022

aaclayton Aug 17, 2022

adrien-schiehle Sep 3, 2022

adrien-schiehle commented Sep 3, 2022

aaclayton commented Sep 5, 2022

	<i title="{{ localize 'WA.ButtonUnshrinkCategory' }}"
	<i data-tooltip="{{ localize 'WA.ButtonUnshrinkCategory' }}"

Compatibility v10 #56

Compatibility v10 #56

Conversation

adrien-schiehle commented Aug 13, 2022

adrien-schiehle commented Aug 13, 2022

adrien-schiehle commented Aug 13, 2022 • edited

aaclayton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adrien-schiehle commented Sep 3, 2022

aaclayton commented Sep 5, 2022

adrien-schiehle commented Aug 13, 2022 •

edited