-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility v10 #56
Merged
aaclayton
merged 19 commits into
foundryvtt:master
from
adrien-schiehle:compatibilityV10
Sep 5, 2022
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
2c83af5
refresh + img fix + category sort
adrien-schiehle 19971c2
Reviews + hidding folderId
adrien-schiehle 7e67771
Review
adrien-schiehle 3ad98c1
V10 compliance
adrien-schiehle 43adee0
Managing entry pages
adrien-schiehle 9e7bca6
compatibility V10
adrien-schiehle 5da8986
compatibility V10
adrien-schiehle f241d34
API Change in WA + Uncategoried fix + Shrinking categories + css
adrien-schiehle 58f99a4
Compatible core version : 10
adrien-schiehle 1d217bb
New shrink button translation
adrien-schiehle ce8dabf
Merge pull request #1 from foundryvtt/master
adrien-schiehle 76193b1
Merge branch 'master' into compatibilityV10
adrien-schiehle d339715
We remove <a .../> element surrounding the image, since now Foundry i…
adrien-schiehle 57e80f0
Relationship management
adrien-schiehle 59814cd
Page names are customisable
adrien-schiehle 8a38e3e
Shrink icon on left part. Better.
adrien-schiehle fbf74e3
module.json v10 compliant
adrien-schiehle 74690f8
shrink => collapsed
adrien-schiehle f7782fd
Using data-tooltip
adrien-schiehle File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These settings feel like a level of customization that may not be necessary to me - I wonder if we could keep it simpler at first and see what feedback we get from users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment bellow.
The parameters are far from being mandatory. An good alternative could be to create translation file for every language. Or ate the least put how to create on with the necessary data inside the Readme file.