Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility v10 #56

Merged
merged 19 commits into from
Sep 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 20 additions & 0 deletions lang/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,25 @@
"WA.ConfigureStep2": "Step 2: Choose which of your available World Anvil worlds you would like to associated with this Foundry VTT World.",
"WA.ConfigureStep3": "Your World Anvil integration is properly configured!",

"WA.JournalPages.ArticleLabel": "Article main page",
"WA.JournalPages.ArticleHint": "Main page name when importing WA article. Default: Article",
"WA.JournalPages.ArticleDefault": "Article",
"WA.JournalPages.SecretsLabel": "Page for secrets",
"WA.JournalPages.SecretsHint": "Will store all secrets. Default: Secrets",
"WA.JournalPages.SecretsDefault": "Secrets",
"WA.JournalPages.SideContentLabel": "Page for detais",
"WA.JournalPages.SideContentHint": "Store addtional informations. Character example : eyes color, weight... Default: Side contents",
"WA.JournalPages.SideContentDefault": "Side contents",
"WA.JournalPages.PortraitLabel": "Page for portrait",
"WA.JournalPages.PortraitHint": "Portrait are used by character articles. Default: Portrait",
"WA.JournalPages.PortraitDefault": "Portrait",
"WA.JournalPages.CoverLabel": "Page for cover",
"WA.JournalPages.CoverHint": "In WA, you can define a cover for each article. Default: Cover",
"WA.JournalPages.CoverDefault": "Cover",
"WA.JournalPages.RelationshipsLabel": "Page for relationships",
"WA.JournalPages.RelationshipsHint": "In WA, you can define relationships between characters. Default: Relationships",
"WA.JournalPages.RelationshipsDefault": "Relationships",

"WA.UserToken": "User Authentication Token",
"WA.UserTokenHint": "Enter a World Anvil user authentication token for your World Anvil account on the Account Management page of your World Anvil user profile.",
"WA.WorldId": "Select World",
Expand All @@ -24,6 +43,7 @@

"WA.ButtonRefreshAll": "Refresh All",
"WA.ButtonImportAll": "Import All",
"WA.ButtonExpandCategory": "Expand category",
"WA.ButtonSyncAll": "Sync All",
"WA.ButtonVisibilityHide": "Hide from players",
"WA.ButtonVisibilityDisplay": "Display to players",
Expand Down
11 changes: 7 additions & 4 deletions module.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
{
"name": "world-anvil",
"id": "world-anvil",
"title": "World Anvil Integration",
"description": "<p>A module to integrate <a href=\"https://worldanvil.com\" title=\"World Anvil\" target=\"_blank\">World Anvil</a> with Foundry Virtual Tabletop.</p>",
"author": "Atropos",
"authors": [],
"url": "https://github.com/foundryvtt/world-anvil",
"version": "1.3.3",
"minimumCoreVersion": "0.7.6",
"compatibleCoreVersion": "9",
"compatibility": {
"minimum": "10",
"verified": "10.284",
"maximum": "10"
},
"scripts": [],
"esmodules": [
"wa.js"
Expand All @@ -24,7 +27,7 @@
],
"packs": [],
"system": [],
"dependencies": [],
"relationships": {},
"manifest": "https://raw.githubusercontent.com/foundryvtt/world-anvil/master/module.json",
"download": "https://github.com/foundryvtt/world-anvil/archive/refs/tags/release-1.3.3.zip"
}
56 changes: 56 additions & 0 deletions module/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,5 +106,61 @@ export default class WorldAnvilConfig extends FormApplication {
config: true
});

// Add the customizable labels for each importable page
//-------------------
game.settings.register("world-anvil", "mainArticlePage", {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These settings feel like a level of customization that may not be necessary to me - I wonder if we could keep it simpler at first and see what feedback we get from users?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment bellow.

The parameters are far from being mandatory. An good alternative could be to create translation file for every language. Or ate the least put how to create on with the necessary data inside the Readme file.

name: "WA.JournalPages.ArticleLabel",
hint: "WA.JournalPages.ArticleHint",
scope: "world",
type: String,
default: "",
config: true
});

game.settings.register("world-anvil", "secretsPage", {
name: "WA.JournalPages.SecretsLabel",
hint: "WA.JournalPages.SecretsHint",
scope: "world",
type: String,
default: "",
config: true
});

game.settings.register("world-anvil", "sideContentPage", {
name: "WA.JournalPages.SideContentLabel",
hint: "WA.JournalPages.SideContentHint",
scope: "world",
type: String,
default: "",
config: true
});

game.settings.register("world-anvil", "portraitPage", {
name: "WA.JournalPages.PortraitLabel",
hint: "WA.JournalPages.PortraitHint",
scope: "world",
type: String,
default: "",
config: true
});

game.settings.register("world-anvil", "coverPage", {
name: "WA.JournalPages.CoverLabel",
hint: "WA.JournalPages.CoverHint",
scope: "world",
type: String,
default: "",
config: true
});

game.settings.register("world-anvil", "relationshipsPage", {
name: "WA.JournalPages.RelationshipsLabel",
hint: "WA.JournalPages.RelationshipsHint",
scope: "world",
type: String,
default: "",
config: true
});

}
}