Resolve eslint operands

fourTheorem · Mar 10, 2023 · e569a67 · e569a67
1 parent 8bcfba9
commit e569a67
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -10,12 +10,12 @@
     "project": "./tsconfig.json"
   },
   "rules": {
+    "@typescript-eslint/no-floating-promises": 0,
     "no-template-curly-in-string": 0,
     "@typescript-eslint/restrict-template-expressions": 0,
     "@typescript-eslint/consistent-type-assertions": 0,
-    "@typescript-eslint/restrict-plus-operands": 0,
-    "@typescript-eslint/explicit-function-return-type": 0, // when there is function they return object?
-    "@typescript-eslint/no-floating-promises": 0
+    "@typescript-eslint/explicit-function-return-type": 0 // when there is function they return object?
+
   },
   "ignorePatterns": ["core/coverage",
   "cf-macro/coverage",

diff --git a/core/dashboards/dashboard.ts b/core/dashboards/dashboard.ts
@@ -68,9 +68,9 @@ export function resolveEcsClusterNameForSub (cluster): string | undefined {
   // AWS::ECS::Cluster returns the cluster name for 'Ref'
   // This can be used as a 'Fn::Sub' variable
   if (cluster.GetAtt != null && cluster.GetAtt[1] === 'Arn') {
-    return '${' + cluster.GetAtt[0] + '}'
+    return '${' + `${cluster.GetAtt[0]}` + '}'
   } else if (cluster.Ref != null) {
-    return '${' + cluster.Ref + '}'
+    return '${' + `${cluster.Ref}` + '}'
   } else if (cluster['Fn::Sub'] != null) {
     return cluster['Fn::Sub']
   }

diff --git a/serverless-plugin/tests/index.test.ts b/serverless-plugin/tests/index.test.ts
@@ -41,7 +41,7 @@ const mockServerless = {
   providers: { aws: {} },
   getProvider: () => ({
     naming: {
-      getLambdaLogicalId: (funcName) => {
+      getLambdaLogicalId: (funcName: string) => {
         return funcName[0].toUpperCase() + funcName.slice(1) + 'LambdaFunction'
       }
     }