TypeScript migration #105
Merged
TypeScript migration #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant resources
- Tidy up the branch
direnakkoc
force-pushed
the
ts-migrate
branch
2 times, most recently
from
477e6d7
to
706f983
Compare
eoinsha
reviewed
Mar 6, 2023
direnakkoc
force-pushed
the
ts-migrate
branch
4 times, most recently
from
3f026c8
to
8bcfba9
Compare
adminy
reviewed
Mar 22, 2023
adminy
approved these changes
Mar 22, 2023
direnakkoc
force-pushed
the
ts-migrate
branch
4 times, most recently
from
139fdf9
to
0a67e48
Compare
adminy
approved these changes
Jun 28, 2023
…rms created by slic watch. This is to force a few naming fixing bugs
- Node 18 is falsely reporting incomplete coverage, so we'll only use Node 20+ coverage reports for measurement in the automated build. (example: https://github.com/fourTheorem/slic-watch/actions/runs/6705742466/job/18220791453)
- This means new resources will be created, so Alarm names are altered too to prevent "already exists" deployment failures
This was referenced Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typescript migrated in this PR. We wanted to have type-safe properties and faster compilation.
Description
Changing your code from JavaScript to TypeScript requires changing files with the .js extension to .ts , adding signatures, building types and interfaces, and making sure nothing breaks in the process.
Instead of changing it all at once, we decided to switch gradually. The method we chose was that during each process, we would migrate only the core folder from js to ts. This way, we ensured that our work wasn’t disrupted, we didn’t feel threatened by the sudden change and our project didn’t suddenly break. When the project broke we managed these errors with eslint rules and added some rules to tsconfig as well. During the process when managing types workaround rules are removed by one. We still have some workaround rules in the eslint and tsconfig module. The aim is to remove most of them when merging this PR.
Cloudform library used at alarms properties level, cloudFormation template level and also dashboard level. We are able to manage all alarm properties with types which come from cloudform lib. But for dashboard body properties there were no types defined. We created an issue for this on cloudform repo. Happy to implement this type in the future if it comes through.
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: