Add API Gateway dashboard and alarms #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eoinsha
commented
Apr 23, 2021
eoinsha
commented
- Switch to cascading configuration for alarms
- Add API Gateway alarms
- Add API Gateway to dashboard
lmammino
reviewed
Apr 23, 2021
lmammino
reviewed
Apr 23, 2021
| @@ -6,8 +6,8 @@ | |||
| SLIC Watch provides a CloudWatch Dashboard and Alarms for: | |||
There was a problem hiding this comment.
I don't know id this is what you were implying earlier, but I am thinking that we might have a build step in our pipeline where this readme is copied over before publish. This way we don't have to checkout a clone of the original file into git...
There was a problem hiding this comment.
That's be great. We would need to update relative links.
An alternative is to have a parent readme that links to the plugin one. I'm okay with either idea.
lmammino
reviewed
Apr 23, 2021
lmammino
reviewed
Apr 23, 2021
lmammino
reviewed
Apr 23, 2021
lmammino
reviewed
Apr 23, 2021
lmammino
approved these changes
Apr 23, 2021
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
Co-authored-by: Luciano Mammino <lucianomammino@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.