Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom resource lambdas #69

Merged
merged 5 commits into from
Nov 4, 2021
Merged

Conversation

eoinsha
Copy link
Contributor

@eoinsha eoinsha commented Oct 25, 2021

Fixes #67

This solution handles functions that are injected by Serverless Framework for Custom CF Resources but also introduces a difference in how such functions are handled between alarms and dashboards. I created #68 to deal with that separately!

@eoinsha eoinsha requested a review from lmammino October 25, 2021 11:14
@coveralls
Copy link

coveralls commented Oct 25, 2021

Coverage Status

Coverage increased (+0.3%) to 100.0% when pulling 9d4552c on handle-custom-resource-lambdas into 18564a7 on main.

@eoinsha eoinsha merged commit d6b45f6 into main Nov 4, 2021
@eoinsha eoinsha deleted the handle-custom-resource-lambdas branch November 4, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError occurs with custom resource Lambdas: Cannot read property 'Errors' of undefined
2 participants