-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schema warnings from Ajv #73
Conversation
# Conflicts: # serverless-plugin/package-lock.json
Hey @eoinsha sorry to be a pain, but any chance you could look at this one? 🙌 |
@@ -71,13 +71,15 @@ const commonAlarmProperties = { | |||
const alarmSchemas = {} | |||
for (const service of Object.keys(supportedAlarms)) { | |||
alarmSchemas[service] = { | |||
type: 'object', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to include these!
@eoinsha I've cleaned up the PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @jakejscott !
With the upgrade to the latest version of Ajv it logs warnings about invalid schema. This PR fixes those warnings
Issue: #74