Add support for ALB alarms and dashboard #97

direnakkoc · 2022-09-26T14:46:25Z

Description

Add support for ALB alarms and dashboard for the metrics are

HTTPCode_ELB_5XX_Count
RejectedConnectionCount
HTTPCode_Target_5XX_Count
UnHealthyHostCount
LambdaInternalError
LambdaUserError

Motivation and Context

HTTPCode_ELB_5XX_Count- The number of HTTP 5XX server error codes that originate from the load balancer. This count does not include any response codes generated by the targets.
RejectedConnectionCount- The number of connections that were rejected because the load balancer had reached its maximum number of connections.
HTTPCode_Target_5XX_Count- The number of HTTP response codes generated by the targets. This does not include any response codes generated by the load balancer.
UnHealthyHostCount- The number of targets that are considered unhealthy.
LambdaInternalError- The number of requests to a Lambda function that failed because of an issue internal to the load balancer or AWS Lambda. To get the error reason codes, check the error_reason field of the access log.
LambdaUserError- The number of requests to a Lambda function that failed because of an issue with the Lambda function. For example, the load balancer did not have permission to invoke the function, the load balancer received JSON from the function that is malformed or missing required fields, or the size of the request body or response exceeded the maximum size of 1 MB. To get the error reason codes, check the error_reason field of the access log.

How Has This Been Tested?

Unit tests added

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING.md document.
I have added tests to cover my changes.
All new and existing tests passed.

coveralls · 2022-09-27T15:21:22Z

Coverage decreased (-0.6%) to 99.358% when pulling f9891ce on fix-alb-metrics into 4590498 on main.

coveralls · 2022-09-27T15:26:23Z

Coverage remained the same at 100.0% when pulling c4c407d on fix-alb-metrics into 7d26f74 on main.

eoinsha

Great work @direnakkoc . The main issue is still with the challenge of associating an ALB Target Group with the correct Load Balancer.
Going back to the original design discussion (#89), we have to find the Listener Rule, then the Listener and only then can we find the Load Balancer!

README.md

serverless-plugin/alarms-alb-target-group.js

serverless-plugin/dashboard.js

serverless-plugin/util.js

serverless-test-project-alb/sls-resources.yml

serverless-test-project/serverless-v2.yml

direnakkoc · 2022-10-11T12:38:11Z

core/util.js

+  for (const [listenerRuleLogicalId, listenerRule] of Object.entries(listenerRuleResources)) {
+    for (const action of listenerRule.Properties.Actions || []) {
+      const targetGroupArn = action.TargetGroupArn
+      if (targetGroupArn.Ref === targetGroupLogicalId) {


Shouldn't we also check here if targetGroupArn exist? like we did above
(targetGroupArn?.Ref === targetGroupLogicalId)

README.md

- Create unit-tests for ALB alarms and ALB Taget Group alarms

- Separate ALB resources in unit-test - Tidy up modules

- Modify alarms.test.js and alarms-lambda.test.js for ALB - Create a new function to find Load Balancers for Target Group

- Correct unit-tests values for load balancer target group widget and alarms

- Create integration test for HTTPCode_Target_5XX_Count metric - Provide pictures of integration tests

- This enables us to use esbuild to bundle the CloudFormation Macro - We don't have to worry about adding a loader for YAML

direnakkoc requested a review from eoinsha September 26, 2022 14:46

direnakkoc force-pushed the fix-alb-metrics branch 7 times, most recently from 23a9cd6 to f9891ce Compare September 27, 2022 15:13

eoinsha requested changes Sep 29, 2022

View reviewed changes

direnakkoc force-pushed the fix-alb-metrics branch 5 times, most recently from 12a072b to 6038136 Compare October 7, 2022 08:23

eoinsha force-pushed the fix-alb-metrics branch from 6038136 to 4df49fb Compare October 10, 2022 12:21

direnakkoc commented Oct 11, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

direnakkoc and others added 11 commits October 12, 2022 23:04

Add support for ALB alarms and dashboard

c73da80

Fix syntax issue in dashboard.js

91ffd61

Fix syntax issue in dashboard.js

258491f

LoadBalancerFullName and TargetGroupFullName update

9d24e07

Update LoadBalancerFullName and TargetGroupFullName

1cdf936

Separate ALB alarms module and ALB Target Group alarms module

826cda6

- Create unit-tests for ALB alarms and ALB Taget Group alarms

Create unit-tests for ALB dashboard and ALB Target Group dashboard

31edcc6

Complete unit-tests

83522e3

- Separate ALB resources in unit-test - Tidy up modules

Trigger Lambda when there is error

78265f4

Tidy up the branch

4818bed

- Modify alarms.test.js and alarms-lambda.test.js for ALB - Create a new function to find Load Balancers for Target Group

Use correct CloudFormationTemplate for load balancer widgets

9244a9a

direnakkoc and others added 12 commits October 12, 2022 23:04

Use correct CloudFormationTemplate for load balancer target group alarms

76b06ad

- Correct unit-tests values for load balancer target group widget and alarms

Correct load balancer logicalID name for target group alarms

f22d07a

- Create integration test for HTTPCode_Target_5XX_Count metric - Provide pictures of integration tests

Make sure Dashboards are named globaly unique

af0a7f0

Move ALB modules into core package

d4cfcde

Update ALB tests to use function configs by logical ID

b056971

Use JS instead of YAML for default-config

6e25753

- This enables us to use esbuild to bundle the CloudFormation Macro - We don't have to worry about adding a loader for YAML

Use esbuild to bundle SLIC Watch macro

ce316e7

Add support for ALB DefaultAction targets

fcf738f

Add a cf-macro test case based on a synthesized CDK template

5a432b1

fix: don't create ALB TG Lambda alarms if Lambda is not the target

27e6156

chore: add more cf-macro unit test coverage

8b82fd0

chore: cover all known permutations of ALB template in tests

6a20708

eoinsha force-pushed the fix-alb-metrics branch from 93141b1 to 6a20708 Compare October 12, 2022 22:04

eoinsha added 2 commits October 12, 2022 23:11

chore: format README intro

82273e9

chore: tidy up ALB widget screenshots

c4c407d

eoinsha approved these changes Oct 12, 2022

View reviewed changes

eoinsha merged commit 6ae11e7 into main Oct 12, 2022

eoinsha deleted the fix-alb-metrics branch October 12, 2022 23:02

eoinsha mentioned this pull request Oct 12, 2022

Build instructions are incorrect for raw CloudFormation #98

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ALB alarms and dashboard #97

Add support for ALB alarms and dashboard #97

direnakkoc commented Sep 26, 2022 •

edited

Loading

coveralls commented Sep 27, 2022

coveralls commented Sep 27, 2022 •

edited

Loading

eoinsha left a comment

direnakkoc Oct 11, 2022

Add support for ALB alarms and dashboard #97

Add support for ALB alarms and dashboard #97

Conversation

direnakkoc commented Sep 26, 2022 • edited Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

coveralls commented Sep 27, 2022

coveralls commented Sep 27, 2022 • edited Loading

eoinsha left a comment

Choose a reason for hiding this comment

direnakkoc Oct 11, 2022

Choose a reason for hiding this comment

direnakkoc commented Sep 26, 2022 •

edited

Loading

coveralls commented Sep 27, 2022 •

edited

Loading