Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Tweaks (in progress) #25

Merged
merged 1 commit into from Apr 23, 2017
Merged

Design Tweaks (in progress) #25

merged 1 commit into from Apr 23, 2017

Conversation

joetower
Copy link
Collaborator

@joetower joetower commented Apr 21, 2017

FKVR-X

This PR introduces the following changes:

  • Added darker version of the windows in Mikes workshop so text is more legible

Steps to Test

  • Checkout this branch.
  • Run yarn or npm i in this repo's root.
  • Run npm run start in this repo's root.
  • Navigate to the IP address:port given to you in the start script output in Chrome on your phone, which should be connected to the same network as your computer. (And not using a VPN).
  • Mike's workshop should look like this:

screenshot 2017-04-21 17 43 41

What needs work:

  • Add close button option to all modals. I'm happy to help with this, but would like to chat approach with you, @patrickocoffeyo , right quick before doing anything.
  • I'd like to figure out how this icon can be the steps icon, too, because this interaction is confusing! You click the x to close but are instead taken to Suzy's shedquarters.
    screenshot 2017-04-21 17 44 31

@patrickocoffeyo
Copy link
Contributor

@joetower This is great! I'm merging in the existing commits in this PR, but leaving the PR and branch open because it's of the remaining items. Let's chat today sometime and talk about the items you outline. I think adding a second button to modals that's always a close button will solve the weird modal action icon swapping issue we're experiencing.

@patrickocoffeyo patrickocoffeyo merged commit 8c137da into master Apr 23, 2017
@patrickocoffeyo
Copy link
Contributor

Well GitHub autoclosed this haha. I fixed everything mentioned in your PR comments and they're being deployed live now. 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants