This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
223: Clarify image directory usage #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
components/images/README.md
Outdated
| @@ -0,0 +1 @@ | |||
| This is Pattern Lab's default images directory. We recommend putting theme images into `/images` or into a relevant component directory. | |||
There was a problem hiding this comment.
Let's specify that they're only for pattern lab. Something like:
This is Pattern Lab's default images directory. Images that only apply to the Pattern Lab instance should be placed here. e.g. One image of each dimension (portrait, landscape, square, etc.) to demonstrate the various components with images.
We recommend putting theme images into the theme's root-level
/imagesdirectory or into a relevant component directory.
There was a problem hiding this comment.
I like this, updated.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple of READMEs to the image directories for clarity. Addresses #223