This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
177: view example using default frontpage view #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had a chance to review yet, but in theory, I'm in favor of adding this kind of thing to Emulsify. Emulsify is an example theme with code that can be copied into custom themes, and adapted as needed. As long as these Drupal-specific files aren't copied over to the cloned theme (or at least not by default) I think they're very useful to have in Emulsify to demonstrate how to map the Drupal data to the PL templates. |
|
Good point - I forget that cloning is now the recommendation rather than an option. In that case, I'm OK with including this as well. |
ModulesUnraveled
approved these changes
Jun 18, 2018
ModulesUnraveled
added
Status: Passes code review
Status: Passes functional review
and removed
Status: Review Needed
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #177
Not sure if we want to go down this road because it's pretty prescriptive, but here's a stab at this. It makes article teasers be a card molecule and the frontpage view be a card grid.
As an alternative, we could either name these files something that has to be renamed to work (e.g.,
templates/content/RENAME_node--article--teaser.html.twig) or not even include these in Emulsify but link to a gist of them (or something like that) from the main README. The latter would be my personal preference, but this is a common request we get.