This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Fix Emulsify Icons #259
Merged
Fix Emulsify Icons #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
icons still not working, only after running |
|
I wonder if you pulled this down before I pushed the updated yarn.lock file. Because pulling this now, and running |
|
@shaal This should be ready for re-review. Would you mind? |
evanmwillhite
added
Status: Passes code review
Status: Passes functional review
Status: Shipit
and removed
Status: Review Needed
labels
evanmwillhite
approved these changes
Jun 22, 2018
|
I'll be able to test it only in half an hour from now
…On Fri, Jun 22, 2018, 16:48 Brian Lewis ***@***.***> wrote:
@shaal <https://github.com/shaal> This should be ready for re-review.
Would you mind?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#259 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABZddfj3OGSKp_fqgZfRSQRam8eN5iEks5t_Vg2gaJpZM4U0Gpk>
.
|
|
It works great! thank you |
|
Awesome! We just tagged a new release v2.6. Thanks for reporting, and helping debug! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the lock files so that
yarnusers are getting the latest requirements.Steps to review:
git@github.com:fourkitchens/emulsify.gitgit checkout icons-fixcomposer installyarn installyarn start