Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Fix PL horizontal scroll #269

Merged
merged 2 commits into from
Jul 7, 2018
Merged

Fix PL horizontal scroll #269

merged 2 commits into from
Jul 7, 2018

Conversation

shaal
Copy link
Contributor

@shaal shaal commented Jul 3, 2018

No description provided.

@shaal
Copy link
Contributor Author

shaal commented Jul 3, 2018

This can fix #261 (this time without CSS Grid)
+
fixing text input fields in the forms that are too wide on narrow screens

Copy link
Contributor

@ModulesUnraveled ModulesUnraveled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I don't like about this is that it creates a difference between how things are done in Pattern Lab and how they're done in Drupal... That said, it does fix the horizontal scroll issue, so I'm going to approve it anyway.

Remove line 19, and I'll merge it


a {
@include wrapper(
$v-padding: $space
$v-padding: $space,
$h-padding: $space / 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This caused weird issues in my testing. Let's remove line 19, and this is good to go

@shaal
Copy link
Contributor Author

shaal commented Jul 7, 2018

I removed line 19

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants