New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add leading-args option for function-arrows #248
Conversation
👋 @brandonchinn178 Reviewer: Please verify the following things have been done, if applicable.
|
719484e
to
83ed553
Compare
bar :: | ||
String | ||
-> String | ||
-> a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original issue suggested that this first argument would be indented like
String
-> String
-> a
but it wasn't trivial to implement that exactly, and I don't see it as a big deal. If a first arg becomes the second arg, you have a diff either way:
-String
+Int
+-> String
-> String
-> a
- String
+ Int
+-> String
-> String
-> a
cc @tchoutri would love to get your feedback here, given that you commented on the original issue. |
9e3b6db
to
20755b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't ever intend to use this, so I won't comment on output. But the implementation looks fine.
20755b8
to
fbe7830
Compare
fbe7830
to
25a465d
Compare
25a465d
to
8132c7a
Compare
Merging now, we can improve upon this later. (Specifically, would like to improve #269) |
Blocked by #247
Resolves #233