Add space after '--' in single-line comments #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @brandonchinn178 Reviewer: Please verify the following things have been done, if applicable.
|
brandonchinn178
commented
Nov 13, 2022
brandonchinn178
force-pushed
the
single-line-comment
branch
2 times, most recently
from
a9c377b
to
0c71220
Compare
brandonchinn178
commented
Nov 13, 2022
Comment on lines
+89
to
+104
| dropPaddingSpace xs = | ||
| case dropWhile T.null xs of | ||
| [] -> [] | ||
| (x : _) -> | ||
| let leadingSpace txt = case T.uncons txt of | ||
| Just (' ', _) -> True | ||
| _ -> False | ||
| dropSpace txt = | ||
| if leadingSpace txt | ||
| then T.drop 1 txt | ||
| else txt | ||
| in if leadingSpace x | ||
| then dropSpace <$> xs | ||
| else xs |
There was a problem hiding this comment.
This is on the Ormolu side. Must've been dropped in a bad merge
https://github.com/tweag/ormolu/blob/54642a7966d1d0787ba84636a2eb52f6729f600e/src/Ormolu/Utils.hs#L89-L102
There was a problem hiding this comment.
Probably me back when I first implemented multi-line-style output. Good find.
brandonchinn178
force-pushed
the
single-line-comment
branch
from
0c71220
to
a9e093f
Compare
brandonchinn178
force-pushed
the
single-line-comment
branch
from
a9e093f
to
37acab7
Compare
|
Nice! This fixes something that has been minorly annoying me for two years. |
georgefst
approved these changes
Nov 23, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212