Leading arrows

[expipiplus1]

This adds a --leading-arrows option and closes #86

It's currently on top of my alignment branch for my convenience, I don't
think it should be that hard to extract though

I've extracted it from on top of my align work, although it's a more convenient for me to have it on there. I'll be keeping that up to date on this branch (joe-align-leading) https://github.com/expipiplus1/fourmolu/tree/joe-align-leading

CC @dpwiz

[expipiplus1]

TODO

data/examples/declaration/class/default-signatures-four-out.hs

-    bar ::
-        String ->
-        String ->
-        a
+    bar
+        :: String
+        -> String
+        -> a

Putting :: on the next line from bar looks weird (same for a few other tests including data/examples/declaration/data/field-layout/gadt-four-out.hs). This is much less of an issue with an indentation of 2 however.

GADTs sometimes look weird.

Should data/examples/declaration/value/function/typed-expressions-four-out.hs have an indented ::

in:

foo x = x::Int
bar x = Just x ::
  Maybe String

out:

foo x = x :: Int
bar x =
    Just x
    :: Maybe String

[expipiplus1]

OK, I've fixed the GADT weirdness, for some reason in Ormolu the existing rendering for GADTs duplicated lots of work from p_hsType

[expipiplus1]

Upstream PR for some changes: https://github.com/tweag/ormolu/pull/711/files

[dpwiz]

You're awesome and your dog is awesome!

[expipiplus1]

[expipiplus1]

If I were to fix the merge conflicts would it stand a chance of getting merged? I think it's quite a sought after feature.

[dpwiz]

It would be merged right away into our fourmolu fork (fourfourmolu? sixteenmolu?).

[arybczak]

Hey. What is the status of this PR? It would be great to have this in fourmolu as "hanging arrows" is not the style I've seen anyone use when writing code without a formatter.

[expipiplus1]

Hey. What is the status of this PR? It would be great to have this in fourmolu as "hanging arrows" is not the style I've seen anyone use when writing code without a formatter.

Probably depends on #49

[brandonchinn178]

👋 @expipiplus1
Thank you for opening this PR and being patient while we sorted out how to handle all the new contributions for new configuration options!

If you haven't noticed, we finally merged in a new testing framework for configuration options (#169)! This means we can finally address the backlog of open PRs.

Please do the following steps

• Rebase against main

  git remote add upstream git@github.com:fourmolu/fourmolu
  git fetch upstream
  git rebase -i upstream/main

• Resolve merge conflicts

• Ensure CHANGELOG.md has been updated

• Ensure configuration docs in README.md have been updated

• Ensure fourmolu.yaml updated to stay in sync with config in README.md

• Ensure tests have been added

You can use #135 as a reference for this checklist.

[expipiplus1]

I did see that! Very exciting. No chance I'll be able to get to this before July, but I'm happy for someone else to take over before then. I'll hopefully find time in July or later otherwise.

…

On Wed, Jun 1, 2022 at 12:59 PM Brandon Chinn ***@***.***> wrote: 👋 @expipiplus1 <https://github.com/expipiplus1> Thank you for opening this PR and being patient while we sorted out how to handle all the new contributions for new configuration options! If you haven't noticed, we finally merged in a new testing framework for configuration options (#169 <#169>)! This means we can finally address the backlog of open PRs. Please do the following steps - Rebase against main git remote add upstream ***@***.***:fourmolu/fourmolu git fetch upstream git rebase -i upstream/main - Resolve merge conflicts - Ensure CHANGELOG.md has been updated - Ensure configuration docs in README.md have been updated - Ensure fourmolu.yaml updated to stay in sync with config in README.md - Ensure tests have been added You can use #135 <#135> as a reference for this checklist. — Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRJXCVWLSQSWGRMOR75ATVM3U2LANCNFSM46SVXTGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[3kyro]

@expipiplus1 I can try rebasing your branch and adding tests if you don't mind.

[expipiplus1]

That would be great :)

…

On Mon, 20 Jun 2022, 8:13 pm Kyriakos Papachrysanthou, < ***@***.***> wrote: @expipiplus1 <https://github.com/expipiplus1> I can try rebasing your branch and adding tests if you don't mind. — Reply to this email directly, view it on GitHub <#95 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGRJXDLY2LVIXX5235CMN3VQC7D3ANCNFSM46SVXTGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[brandonchinn178]

Closing in favor of #209