Incorrect empty line before next boundary #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No empty line / seperator after parameter value. http://www.ietf.org/rfc/rfc1867.txt doesn't specify this newline, and Amazon S3 doesn't support newlines (it's treated as part of the value)
|
Thanks for the fix! |
itsbonczek
added a commit
that referenced
this pull request
Dec 19, 2012
Incorrect empty line before next boundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No empty line / seperator after parameter value before the next boundary. http://www.ietf.org/rfc/rfc1867.txt doesn't specify this newline. This is an issue when uploading an object upload to Amazon's S3 API. It seems their HTTP server treats the newline as part of the value, which is correct according to the RFC. Removing the empty line made the object upload work.