Visit refresh fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 21, 2017 14:51
This reverts commit ffd22ad.
Prevent visits from being turned off if they were already on
mdyson
reviewed
Jun 21, 2017
mdyson
reviewed
Jun 21, 2017
| @@ -514,17 +514,16 @@ - (void)refreshVisitSubscribers { | |||
| - (void)locationManager:(CLLocationManager *)manager didUpdateLocations:(NSArray *)locations { | |||
|
|
|||
| BOOL isBackgrounded = applicationIsBackgrounded(); | |||
| CLLocation *mostRecentLocation = [locations firstObject]; | |||
| CLLocation *newestLocation = nil; | |||
There was a problem hiding this comment.
I thought this change was something positive for us
There was a problem hiding this comment.
We don't have an immediate benefit from this fix, and don't want to accidentally mess anything up.
samgro
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.