Handling the way filters deal with empty lists #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filters assumed lists to always contain elements, the case of empty lists was not handled correctly. Now we check for empty lists in stored and expected values when applying the filter.
|
I would like to add another commit to this during the day - my problem lies in findOne comparison of lists |
added 2 commits
August 8, 2013 11:35
The unit test for the FongoDbCollection better explains the actual problem. The solution in ExpressionParser is now more general, but should be reviewed whether it is maybe too general.
hoffrocket
added a commit
that referenced
this pull request
Aug 18, 2013
Handling the way filters deal with empty lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters assumed lists to always contain elements, the case
of empty lists was not handled correctly. Now we check for
empty lists in stored and expected values when applying the
filter.
Having this data:
{ "_id" : 1 , "title" : "The Hobbit" , "numberOfPages" : 293 , "characters" : [ ]}A findOne(obj) would not find the document in Fongo, but does
find it in the real mongo.