Random keys #6
Merged
Random keys #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| next, err = it.Next() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| } | ||
| lastFound := found-1 |
There was a problem hiding this comment.
this pads out the sample by repeating the last one?
There was a problem hiding this comment.
Yes. Without it you end up with a bunch of nil keys at the end. The scala
code rewinds the cursor, which is not great either. I might switch to using
reservoir sampling.
On Mon, Oct 5, 2015 at 7:58 AM, David Taylor notifications@github.com
wrote:
In rpc.go
#6 (comment):} next, err = it.Next() if err != nil { return nil, err } }
lastFound := found-1this pads out the sample by repeating the last one?
—
Reply to this email directly or view it on GitHub
https://github.com/foursquare/quiver/pull/6/files#r41153473.
There was a problem hiding this comment.
As discussed offline, I think my preference would be to just return a smaller RandomKeys, e.g. buf[:found].
surajacharya
force-pushed
the
RandomKeys
branch
from
620f477
to
51b454d
Compare
fewer keys might be returned than requested
surajacharya
force-pushed
the
RandomKeys
branch
from
51b454d
to
dffce9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.