Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neo (netkiller): #75

Closed
wants to merge 2 commits into from
Closed

Neo (netkiller): #75

wants to merge 2 commits into from

Conversation

netkiller
Copy link

- add function escape_ansi()
- add new feature, ansi color text for table

    - add function escape_ansi()
    - add new feature, ansi color text for table
@foutaise
Copy link
Owner

Hi @netkiller

Thanks for your PR, but I don't want to add color support to texttable.
I already provided an answer on this topic in the past (cf #14).

I can add two more reasons specific to this PR:

  1. I played a bit with your version, and in order to
    get color working on windows, I had to add a call
    to colorama.init(convert=True) in order to get colors
    displayed properly. Depending on the target OS, the
    code has to be changed in order to work properly.

  2. the regexp used to remove the ansi sequences is
    pretty rough, does not handle all kind of ansi sequences
    (does not support semicolon separated sequences,
    does not support every kind of ansi sequences, etc...).

As I'm the maintainer of this lib, I don't want to deal with
semi-implemented features that would generate a lot of
issues because of edge cases not handled properly.

Feel free to fork if you want to add color support on your own.
Thanks for your PR and for your interest on this library.

Best regards.

@foutaise foutaise closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants