Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor history module and add cookies for Chrome #127

Merged

Conversation

Poeloe
Copy link
Contributor

@Poeloe Poeloe commented Feb 9, 2024

(DIS-2135)

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0102794) 41.24% compared to head (89d1b13) 41.24%.

Files Patch % Lines
acquire/acquire.py 46.15% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   41.24%   41.24%           
=======================================
  Files          26       26           
  Lines        3285     3297   +12     
=======================================
+ Hits         1355     1360    +5     
- Misses       1930     1937    +7     
Flag Coverage Δ
unittests 41.24% <46.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Poeloe Poeloe force-pushed the feature/refactor-history-module-and-add-cookies-for-chrome branch from bcd6cf3 to bb5d116 Compare February 9, 2024 09:58
@Poeloe Poeloe changed the title Refactor history moodule and add cookies for Chrome Refactor history module and add cookies for Chrome Feb 9, 2024
@Poeloe Poeloe force-pushed the feature/refactor-history-module-and-add-cookies-for-chrome branch 4 times, most recently from 8c568dd to 3c62a90 Compare February 9, 2024 14:47
@Poeloe Poeloe force-pushed the feature/refactor-history-module-and-add-cookies-for-chrome branch from 3c62a90 to 89d1b13 Compare February 9, 2024 14:53
@Poeloe Poeloe merged commit 1bfc03d into main Feb 12, 2024
16 checks passed
@Poeloe Poeloe deleted the feature/refactor-history-module-and-add-cookies-for-chrome branch February 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants