Pass context when reading a compiled Structure or Array #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After allowing nested arrays in previous commits, only the parent type would have access to the context while resolving expressions. This changeset updates the compiled so that other fields' values are passed as context so that sublevel arrays can also resolve their size from an expression correct. A test has been written to verify this change.
Codecov Report
@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 20 20
Lines 1696 1696
=======================================
Hits 1493 1493
Misses 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After allowing nested arrays in previous commits, only the parent type would have access to the context while resolving expressions in order to calculate their size.
This changeset updates the compiler so that other fields' values are passed as context so that sublevel arrays can also resolve their size from an expression correctly. A test has been written to verify this change.