Add support for Parallels HDD/HDS and PVS #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 57.98% 60.96% +2.98%
==========================================
Files 26 29 +3
Lines 2135 2375 +240
==========================================
+ Hits 1238 1448 +210
- Misses 897 927 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pyrco
requested changes
Apr 14, 2023
cecinestpasunepipe
requested changes
Apr 17, 2023
| self.cluster_size = self.header.m_Sectors * SECTOR_SIZE | ||
|
|
||
| self.data_offset = self.header.m_FirstBlockOffset | ||
| self.in_use = self.header.m_DiskInUse == c_hdd.SIGNATURE_DISK_IN_USE |
There was a problem hiding this comment.
I would recommend to use braces here to visually distinguish the comparison from the assignment. But this is personal taste.
There was a problem hiding this comment.
Black removes those unfortunately, and I don't think it warrants a # nofmt.
pyrco
requested changes
Apr 18, 2023
cecinestpasunepipe
previously requested changes
Apr 18, 2023
pyrco
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds parser for Parallels HDD/HDS files and Parallels PVS descriptor files.