Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OVF XML disk parsing #25

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fix OVF XML disk parsing #25

merged 2 commits into from
Oct 6, 2023

Conversation

Schamper
Copy link
Member

The disk reference doesn't always include a ovf: prefix.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #25 (86c134a) into main (ac6628c) will increase coverage by 0.61%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
+ Coverage   61.08%   61.70%   +0.61%     
==========================================
  Files          29       29              
  Lines        2377     2384       +7     
==========================================
+ Hits         1452     1471      +19     
+ Misses        925      913      -12     
Flag Coverage Δ
unittests 61.70% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
dissect/hypervisor/descriptor/ovf.py 97.05% <100.00%> (+67.42%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Schamper Schamper merged commit 0f04ac2 into main Oct 6, 2023
18 checks passed
@Schamper Schamper deleted the fix-ovf branch October 6, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants