Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read MFT records based on segment numbers #29

Merged

Conversation

Zawadidone
Copy link
Contributor

No description provided.

@Zawadidone
Copy link
Contributor Author

As part of fox-it/dissect.target#665

dissect/ntfs/mft.py Outdated Show resolved Hide resolved
dissect/ntfs/mft.py Outdated Show resolved Hide resolved
dissect/ntfs/mft.py Outdated Show resolved Hide resolved
Read MFT records based on segment numbers
@Zawadidone Zawadidone requested a review from Schamper April 9, 2024 08:26
dissect/ntfs/mft.py Outdated Show resolved Hide resolved
@Schamper
Copy link
Member

Schamper commented Apr 9, 2024

Can you also add the arguments to the docstring?

@Zawadidone Zawadidone requested a review from Schamper April 9, 2024 09:49
dissect/ntfs/mft.py Outdated Show resolved Hide resolved
dissect/ntfs/mft.py Outdated Show resolved Hide resolved
@Zawadidone Zawadidone requested a review from Schamper April 9, 2024 13:30
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.46%. Comparing base (6b5065f) to head (e84e60d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   87.43%   87.46%   +0.03%     
==========================================
  Files          11       11              
  Lines        1234     1237       +3     
==========================================
+ Hits         1079     1082       +3     
  Misses        155      155              
Flag Coverage Δ
unittests 87.46% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Schamper Schamper merged commit 5d2c94f into fox-it:main Apr 9, 2024
16 checks passed
@Zawadidone Zawadidone deleted the feature/mft_recordds_segment_numbers branch April 9, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants