Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset offset of file-object #20

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

Zawadidone
Copy link
Contributor

fh.seek(0) does not work when the LINK header starts at offset != 0.

Miauwkeru
Miauwkeru previously approved these changes Apr 13, 2023
Co-authored-by: Stefan de Reuver <9864602+Horofic@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #20 (cc82794) into main (7375644) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   69.10%   69.20%   +0.10%     
==========================================
  Files           4        4              
  Lines         301      302       +1     
==========================================
+ Hits          208      209       +1     
  Misses         93       93              
Flag Coverage Δ
unittests 69.20% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/shellitem/lnk/lnk.py 82.24% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Horofic Horofic self-requested a review April 13, 2023 08:49
@Horofic Horofic merged commit 88f7fba into fox-it:main Apr 13, 2023
@Zawadidone Zawadidone deleted the fix/header_offset branch April 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants