Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LVM2 volume names containing hyphens #245

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

Schamper
Copy link
Member

(DIS-1982)

@Schamper Schamper self-assigned this Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #245 (b5d9b76) into main (e3a68de) will increase coverage by 0.01%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #245      +/-   ##
==========================================
+ Coverage   68.33%   68.34%   +0.01%     
==========================================
  Files         217      217              
  Lines       16894    16894              
==========================================
+ Hits        11544    11546       +2     
+ Misses       5350     5348       -2     
Flag Coverage Δ
unittests 68.34% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dissect/target/volumes/lvm.py 43.90% <0.00%> (ø)
dissect/target/plugins/os/unix/_os.py 77.59% <100.00%> (+1.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Schamper Schamper merged commit 6e02f7a into main May 2, 2023
17 of 18 checks passed
@Schamper Schamper deleted the dis-1982_fix-lvm2-hyphens branch May 2, 2023 14:43
Poeloe pushed a commit that referenced this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants